Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zutty: init at 0.16-unstable-2024-08-18 #336255

Merged
merged 1 commit into from
Sep 21, 2024
Merged

zutty: init at 0.16-unstable-2024-08-18 #336255

merged 1 commit into from
Sep 21, 2024

Conversation

rolfschr
Copy link
Contributor

@rolfschr rolfschr commented Aug 21, 2024 •
edited
Loading

Description of changes

This PR adds zutty, a terminal emulator.

It is based (and improves) on this previous PR which is now outdated. Compared to that, there are several improvements:

  • A basic test is added
  • src has been updated (on GitHub anymore)
  • The "font path" issue discussed there has been addressed (see this comment, too)
  • A newer version of zutty is used that contains a fix for certain fonts (see details here)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@rolfschr rolfschr marked this pull request as ready for review August 21, 2024 05:06
@s0me1newithhand7s
Copy link
Contributor

s0me1newithhand7s commented Aug 21, 2024 •
edited
Loading

i'll test on x86_64-linux asap, and after OfBorg eval.

@rolfschr
Copy link
Contributor Author

rolfschr commented Aug 21, 2024 •
edited
Loading

ofBorg fails with error: evaluation aborted with the following error message: 'lib.customisation.callPackageWith: Function called without required argument "glew-egl" at /ofborg/checkout/1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-4/pkgs/by-name/zu/zutty/package.nix:10'

I don't know what the problem is. Initially, I thought that this is because glew-egl is not supported on all platforms but zutty's package definition is for linux only anyways.

@rolfschr
Copy link
Contributor Author

rolfschr commented Sep 2, 2024

Ah, I found the issue, I need to use glew instead of glew-egl. See here.

@rolfschr
Copy link
Contributor Author

rolfschr commented Sep 4, 2024

ofBorg has okay'ed everything except "zutty.passthru.tests on aarch64-darwin" which will be skipped (darwin is not supported).

@s0me1newithhand7s This looks good to me now. Could you have a look into this, please?

@wegank You had checked #257156 so could you maybe approve & merge here? I think the other PR could then be closed.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4522

@rolfschr
Copy link
Contributor Author

@JJJollyjim You've been designing (I think) nixos/tests/terminal-emulators.nix so you might be a good candidate for review/merging. Would you mind doing so? Thanks.

@rolfschr
Copy link
Contributor Author

@AndersonTorres You had previously merged a terminal emulator-related PR. Could you have a look into this and possibly merge?

@rolfschr rolfschr changed the title zutty: init at 0.16-1-g04b2ca3 zutty: init at 0.16-unstable-2024-08-18 Sep 21, 2024
s0me1newithhand7s
s0me1newithhand7s approved these changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@s0me1newithhand7s s0me1newithhand7s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank
Copy link
Member

wegank commented Sep 21, 2024

Result of nixpkgs-review pr 336255 run on aarch64-linux 1

1 package built:
  • zutty

@wegank wegank merged commit 1b1e09e into NixOS:master Sep 21, 2024
29 of 31 checks passed
@s0me1newithhand7s
Copy link
Contributor

congrats!

@rolfschr rolfschr mentioned this pull request Sep 22, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wegank wegank wegank left review comments

@s0me1newithhand7s s0me1newithhand7s s0me1newithhand7s approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: maintainer-list (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rolfschr @s0me1newithhand7s @nixos-discourse @wegank @quag